My joycons - original ones even! - finally started to drift earlier this year, and I did the same thing replacing them with some hall effect ones. So far I've been really pleased with the results, though initially it was a little weird simply because the sticks themselves felt a tiny bit different than the original ones. But after using them for a bit they felt good.
My Joycons have survived BotW, AC:NH, Three Houses, Metroid Dread and Metroid Prime, which I all played religiously. But they finally started drifting during my early hours of TotK. I just bought the Gulikit ones, switched them in less than half an hour. Great experience, no complaints, just not drifting joy cons.
Those are the same ones I installed in my joycons, too. And looks like the same ones in the photo on this post.
I had the same experience with the usage, AND I played a lot of Smash Bros. on them which would, in theory, destroy them in no time. But they started to drift about two months before ToTK came out, and I couldn't risk playing that all janky.
I played most of TOTK with a controller because my joycon camera drift really messed with the gyro. Got the hall effect sticks installed last week and I'm hoping this is the end of drift for me.
I saw a few posts on twitter about these hall effect sticks still presenting with drift even with calibration. Not sure why, but I hope it's just user error that can be corrected and not another hardware problem.
I’ve had mine installed for at least a couple months now. Played a lot of Zelda with them, and so far I haven’t had any issues with them.
For me it was worth a shot to try because it was cheaper than buying new joycons. And I didn’t want to send them off right before Zelda came out since I didn’t know when they’d come back (and they’d still be susceptible to drift later on).