Windows feature that resets system clocks based on random data is wreaking havoc
Windows feature that resets system clocks based on random data is wreaking havoc
Windows Secure Time Seeding resets clocks months or years off the correct time.
STS (Secure Time Seeding) uses server time from SSL handshakes, which is fine when talking to other Microsoft servers, but other implementations put random data in that field to prevent fingerprinting.
You're viewing a single thread.
This bug has created havocs for me. We had a “last synchronized” time stamp persisted to a DB so that the system was able to robustly deal with server restarts / bootstrapping on new environments.
The synchronization was used to continuously fetch critical incident and visualize them on a map. The data came through a third party api that broke down if we asked for too much data at a time, so we had to reason about when we fetched data last time, and only ask for new updates since then.
Each time the synchronization ran, it would persist an updated time stamp to the DB.
Of course this routine ran just as the server jumped several months into the feature for a few minutes. After this, the last run time stamp was now some time next year. Subsequent runs of the synchronization routine never found any updates as the date range it asked for didn’t really make sense.
It just ran successfully without finding any new issues. We were quite happy about it. It took months before we figured out we actually had a mayor discrepancy in our visualization map.
We had plenty of unit tests, integration tests, and system tests. We just didn’t think of having one that checked whether the server had time traveled to the future or not.
If I've learned one thing from the last decade of movie and TV sci-fi, it's that you always need to account for the possibility of time travel.
Reminds me of a "bug" in a genealogy software which crashed for a client. Turns out the client had incest and entering the relation in the software caused a loop in the family tree.
Why put "bug" in quotes? If a program crashes because of unexpected user input, that's always a bug.
Unexpected input 😏
That’ll be one weird regression test. Imagine the comment you’ll have to write to explain “why” this test exists.
While the root issue was still unknown, we actually wrote one. It sort of made sense. Check that the date from isn’t later than date to in the generated range used for the synchronization request. Obviously. You never know what some idiot future coder (usually yourself some weeks from now) would do, am I right?
However, it was far worse to write the code that fulfilled the test. In the very same few lines of code, we fetched the current date from
time.now()plus some time span asdate.to, fetched the last synchronization timestamp from db asdate.from, and then validated thatdate.fromwasn’t greater thandate.to, and if so, log an error about it.The validation code made no logic sense when looking at it.
I feel like the 3rd party API should have had some error checking, although that might have strayed too far into a client's business logic.
If it is an API of incidents, that suggests past incidents. And the whole "never trust user data" kinda implies they should throw an error if you request information about a tinerange in the future.
I guess, not throwing an error does allow the 3rd party to "schedule" an incident in the future, eg planned maintenance/downtime.But then, that isn't separation of concerns. Ideally those endpoint would be separate. One for planned hypothetical incidents and one for historical concrete incidents.
It's definitely an odd scenario where you are taking your trusted data (from your systems and your database), then having to validate it.
// for possible time travel scenarios // DO NOT DELETE!lol I have to add this to the code now 😝