17h ago

Do not pass go Do NOT align unspecified stuff

Description, because "alt text" can't show it well:

cpp

    
            {
                emit differentFiles (ckFile.absoluteFilePath(),
                    otherFile.absoluteFilePath(),
                    FileCompareWorker::FileComparisonParams{FileComparisonParams::FileNameMatch,
                        (ckFile.size() > otherFile.size()) ? FileComparisonParams::File1IsLarger
                            : FileComparisonParams::File2IsLarger});
            }

After Alignment

cpp

    
            {
                emit differentFiles (ckFile.absoluteFilePath(),
                    otherFile.absoluteFilePath(),
                    FileCompareWorker::FileComparisonParams{FileComparisonParams::FileNameMatch,
                        (ckFile.size() > otherFile.size()) ? FileComparisonParams::File1IsLarger
                                                           : FileComparisonParams::File2IsLarger});
            }

15 comments

Like the other commented said, this isn't random, but also I'd add that your first ternary option, the ?, should be on the next line; it would make the alignment make more sense to you then, and it would make the block more legible.
- I think I'd rather go with the ? being on the same line as the 'condition' and the rest can go on the other line.
  Otherwise, I'd be looking one line downwards and then coming back up after realising that it is a (cond)?ex:ex operator.
  And I get that it's not random, just that I asked for it at as many places as possible to not do alignment.
  And from what I can recall, I had managed to make stuff work with the older clang-formats...
  Or maybe not. Maybe this kind of code never went through it.

15 comments