Skip Navigation

Merge then review

Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.

144

You're viewing a single thread.

144 comments
  • Something like that happened to me yesterday. I reviewed one PR, then some Important Guy came in and said:

    • it is nice you reviewed my work, but we need to push this to production right now.
    • just fix these things, I described you how. Just copy/paste these snippets
    • these are cosmetics, I don't care
    • "cosmetics", huh? Your shit may just crash
    • gfy and push this to production right now
    • well, ok

    Of course, lack of these "cosmetics" caused crash in production. It's my fault of course.

You've viewed 144 comments.