Pretty critical PR for rust-msi is getting held up because the maintainer understands the intent but not why this works
Pretty critical PR for rust-msi is getting held up because the maintainer understands the intent but not why this works
Hi! Thank you for your work, I tried to play with it and figured out that there is an issue with the long string. Basically, it doesn't read fully long string and after that, all strings are messed...
Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer's understanding while a similar C implementation does not need this fix. Clearly, the maintainer has not heard a certain programming mantra...
You're viewing a single thread.
while a similar C implementation does not need this fix
No, that implementation also needs the fix. It's just that it was never properly tested, so they thought it was working correctly.
They tested the same strings on that implementation., though judging by the recent comments someone’s found something.
They tested the same strings on that implementation
The strings were the same, but not the implementation. They were testing the decoding of the strings, but the C function they were looking at was the one for encoding them. The decoding function was correct but what it read didn't match the encoding one.
though judging by the recent comments someone’s found something.
Yeah, that's me :)