Switch pro controller previously and Xbox controller lately. I especially like the detachable AA batteries of the Xbox controller as I can charge extra batteries separately.
Honestly, it's still the F310 for me. I have mine since the early 2010s and it's still working perfectly. Those things are built like tanks and between XInput and DirectInput are compatible with just about any PC game of the last forty years, no extra software required. Also, they're dirt cheap.
Honorable mention to the F710, the wireless version. While Windows 10's USB stack unfortunately broke compatibility with it (causing randomly dropped inputs), Linux does not have that problem.
At the moment, my PS5 controller connected to my Linux PC via USB-C.
It has perfect support due to official in kernel drivers from Sony and very little lag when used via USB-C.
I'm switching to Linux when I get set up again. Fuck the Recall bull shit. Straw that broke the camels back. I had not considered controller drivers. Is Xbox One over Bluetooth a thing, or will I need to go with Sony?
The XBOX One controller should be fully bluetooth hid compliant and it should work out of the box for at least all the buttons and axis.
There are userspace and kernel drivers for the XBOX controller too (xpad and xboxdrv) but I don't have much experience with them or with bluetooth controller in general.
i miss the black and white buttons from the mini xbox controller days. still feel like 4 buttons is not enough on the right pad, especially considering how often games use L3/R3 joystick click which i fucking loathe.
First of all, favorite for what? For accesibility reasons if it's not a dual stick game I am defaulting to a fightbox-type device these days. I favor a WASD configuration, rather than a thumb-for-up configuration and I currently favor a tiny, minimalist haute board box with cherry switches (blue for buttons, greys for WASD). It's great, it lies on my desktop and it causes minimal strain even in high APM games.
For dual stick stuff, it again depends. Is this a shooter where aiming is a factor? Because then I'm gonna want some gyro. The DualSense is amazing to hold, just bonkers build quality. It is heavy and ugly as sin, though. It also doesn't work perfectly with every PC game, so it feels like a hassle to use it as my default. There's the KK3, which has gyro in Switch mode and seems to be less fussy than the DualSense. Plus they are trying to sell their hall effect sticks to third parties, so those are very smooth. It is a jack of all trades, though, and I actively hate KK's dumb extra button configuration, with start and select all the way at the top, I keep pressing the screenshot buttons by accident.
If there's no twitch aiming, and thus no major need for gyro, Victrix's Pro BFG is fun. It has modular design where you can put the dpad on either location. The dpad isn't great, but hey, the fightbox's there for that. It does have a six button configuration, too, if you're a controller fighting game guy. The best feature, though? Replaceable eight-way gates for the sticks, Gamecube-style. If you're a Smash guy or emulating Gamecube it's such a no-brainer high end replacement.
But honestly? Honestly?
The JoyCon.
I know people hate the JoyCon, but the idea of a split controller is amazing to me, and everybody else who has tried to do it, Lenovo Legion Go included, gets it wrong. The big handles aren't the answer without a middle segment to hold the controllers. The two little boards are fantastic for 3D action games, the amount of tech in such a small frame is astounding and the button-based dpad is so good I'm using fightboxes on the regular now. It's a shame there are some reliability issues, but I would buy a device just like it for PC tomorrow if they could sort out connectivity reliably.
For fighting games, my own custom built stick. Put this together last year to replace the Hori RAP4 that had served me well for seven years until a button cap broke off. Super happy with how this turned out. It's much lighter, I like having a detachable cable. GP2040-CE supports Switch natively so I no longer need an adapter (and I can feel the difference in latency now), and Sanwa silents mean I can practice late at night without keeping anyone awake. And it just looks good, it's on brand for me.
For everything else that is not fighting games, 8BitDo Pro 2.
I also have a soft spot for the Wii Classic Controller Pro, I miss having gates on the analog sticks. I'd kill for a modern refresh of that with L3/R3, gyro, and USB instead of having to plug it into a Wiimote.
deck is mostly more input options (right stick, d-pad, 4 back buttons instead of 2).
the biggest difference is the placement of the touchpads imho, as i cant use both shoulder buttons and the touchpad on a side without adjusting my grip, but that only mattered in shooters for which i use flickstick on the deck and not the right touchpad.
An Xbox one controller. I bought a newer seriesX controller but it developed stick drift almost immediately. My Xbox one controller is going on 6 or 7 years now and is still rock solid. And I play rocket league so you know I am hard on them.
Switch Pro controller for its asymmetrical layout + gyroscope (it’s so much better for aiming). I’d love to test a PS5 controller but symmetrical layout tend to hurt my hands (it was already the case for the PS3/PS4 controllers, so I have little hope for the PS5 controller).
I think the gyro and layout of the switch pro controller are good, but it just feels so cheap, and the buttons are way too mushy. Also doesn't have analogue triggers. The d-pad is pretty terrible as well.
To be specific, the Xbox One Elite controller. I really liked the Series 2 but it fell apart on me. I never had much issue with the original. I'm a glutton for punishment though, and I'd get another Series 2. I don't mind working on them so it isn't the biggest deal
I really love the Switch Pro controller, but I wish it had analog triggers. I also have love for the GameCube controller. I am at home with the N64 controller, but I can't say it's a favorite
It's probably because I have bias, but I've never cared for any of Sony's offerings. Something about the sticks doesn't feel right with both being at the bottom
My series 1 ended up developing a pretty bad flaw with the input chip and is dead-dead. It also developed a sticky X button right away, which I could repair but went back to not being perfect. The Series 2 has been more reliable, but I also use it less.
I grew up with the PS Dualshock and Dualshock 2 controllers. They were all I ever knew as a kid. But, I absolutely prefer the XBox layout now as well. Something about it just works better for me. On the other hand, my wife also only knew PS growing up and she just can't get used to the XBox layout.
Right now, a kind of weird one: the Bridget MX, from SGF Devices. It's a 3D printed, all-button controller for fighting games. They don't make that specific model now (it was a very early one), but this is the closest to it: https://sgfdevices.com/products/bridget-pe
At first I thought that not having a joystick would make games kind of boring. Like, too practical, not enjoyable. But no, it's actually fun. Kind of like tapping out notes on a piano. It uses low-profile mechanical keyboard switches, and I have some stiffer, clickier switches on the way right now.
It's meant for fighting games (Street Fighter, etc.), but I've used it for some 2D platformers and it worked great for those, too.
A non-3D-printed, less cheapo one would probably be even more fun to use, but I think I'll stick with this one for now.
Right now I’m mostly using the Xbox One controller (on PC). It’s a controller that feels really good to hold. No weird gimmicks like motion control either. I think it’s one of the all time bests.