Merge then review
Merge then review
![](https://programming.dev/pictrs/image/de660c5d-e1cd-4ac7-a0e1-a5b235046bc6.png?thumbnail=1024&format=webp)
Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.
You're viewing a single thread.
View all comments
144
comments
Something like that happened to me yesterday. I reviewed one PR, then some Important Guy came in and said:
- it is nice you reviewed my work, but we need to push this to production right now.
- just fix these things, I described you how. Just copy/paste these snippets
- these are cosmetics, I don't care
- "cosmetics", huh? Your shit may just crash
- gfy and push this to production right now
- well, ok
Of course, lack of these "cosmetics" caused crash in production. It's my fault of course.
9 0 Reply
You've viewed 144 comments.
Scroll to top