I'm gonna be a snob about it and say that it really depends on the coffee. An Ethiopian coffee from anaerobic fermentation: hot. Honey-process Colombian coffee, iced.
I'm a specialty coffee roaster and I also brew all of our cold brew, at a previous job I made the recipe for our 400+ gallon batches on converted beer brewing equipment. Here's my actual recipe I'm currently using:
I respect the fact that people are connoisseurs of coffee or wine or whatever—you do you, I'm not about to argue for the case that there's an overabundance of joy in the world—but tbh your method sounds like a decent method as it is.
I'm not convinced that specialised lab equipment or scentific methods is necessary for cold brew tbh.
Btw I used to love doing cold brew green tea in a similar way: get a large container, put a decent amount of green tea leaves in it (a smaller nut milk bag that is the size of a wallet or a bit bigger is really good for this, you can get them cheap online) and leave it overnight. Do not remove the tea leaves. When you pour a glass, refill the jug with more water and you can go like that for 3+ days, depending on how much you drink and how much tea leaves you add.
It's really good for the hot summer months, it's more delicate than hot-steeped green tea (that westoids almost invariably butcher by making it overly strong and using overly hot water) but it's nice.
Depending on how much you consume or how big your household is you might want to go for a 1L container or you might opt for like a 3L one. Whatever the case, you can absolutely wring every last cent out of your green tea leaves with this method and it's really minimal effort too.
I'm somewhat of a coffee enthusiast, and honestly that's all there is to cold brew. I prefer hot brew over ice because more smell, but other than that it's good!
If you want to improve the taste of your coffee, buying whole bean coffee and grinding it yourself will take you 80% of the way to the platonic ideal of coffee, so if you don't do either or both things already, that's a good place to start.
If you can put the grounds in a bag or filter, it'll save a lot of time in the future when you might want to filter it so it's not like drinking sand or silt.
Also if you choose to filter, know that filtering can take a long time because the smaller grounds can clog up the pores. So go from filtering course to fine eg. use a sieve, then cheesecloth, then paper coffee filters, etc. based on how filtered you want it or your patience
16-20 hrs is pretty ideal unless you just want it very strong. Be sure to mix the grounds and water well (let the grounds 'bloom' with the water for a minute before sealing/covering). The grounds ideally will be on the course side and fairly fresh. 4-to-1 ratio of water to grounds is what I use. Medium to dark roast is good to get a strong flavor, and cold brewing doesn't extract much bitterness at all. In my personal experience more floral/fruity-forward beans/roasts don't work so well for my flavor preferences. I enjoy hot brew of fruity/floral beans, but as cold brew it's just not very appealing in my opinion.
Hot, ideally something like an espresso or a simple drip or pourover. That said I don't shy away from a cold brew or iced coffee. Regardless of the state it has to be black.
Iced coffee because I drink it quickly to get ready and stay awake for a work day. It’s funny because many of the immigrants I know from poorer countries tend to have ample time in the morning for a proper breakfast with the family and enjoy coffee at a leisurely pace
I've been living in Vietnam for about a year and a half now, and iced is almost always the way to go here. Bạc Xỉu is my jam forever. If you can find a Vietnamese coffee shop in your area, I'd highly recommend it. Bonus points if they are using Vietnamese Robusta beans instead of Arabica.
Espresso is my go to at work, but I also don't have any form of coffee at home. I've some fancy Oolong and Pu'er but no coffee, since that would involve buying an espresso machine and that's bourgeoisie. But if I did have coffee at home, I'd probably opt for cold brew simply because I can prepare it ahead of time.
But, if you've ever arrived to work still drunk on a Sunday morning for the brunch shift, 2 shots of espresso pair well with a cigarette. Really preps you mentally for the onslaught of white folk arriving after church and changing things on the menu just to feel powerful.
Just still buzzed on alcohol, noticeable heartbeat from the lack of sleep and double strength espresso, making bruschetta and salads on auto pilot for people who still dress fancy for church. Contemplating whether or not you should message the girl that cheered the loudest when you drunkenly yelled "Free Palestine" in someone's living room while you were 11 shots deep the night before.
Actually, shit sucks, I'm romanticizing it too much.