7d ago

Pre-Release Notes for 1.4.30

Finally have a feature-freeze on 1.4.30 and am in the final shakedown phase and fixing last minute bugs. If anyone would want to or be willing to run the beta and report any bugs, it would be appreciated.

Docker Tag: ghcr.io/asimons04/tesseract:1.4.30-beta.3

Update: Posted beta 3 just a moment ago.

Changes in Beta 3:

Bugfix for post titles mangling when they start with {number}. which was incorrectly rendering as a list item.
Partially re-written modal subsystem that is now history-based. This means you can now close modals by navigating "back" (browser back button, mouse back button, swipe gesture, etc).

New Features

You're viewing a single thread.

21 comments

I tested the new modal and it's actually quite hard to close that thing.
The only way to close the modal is using the small X in the upper right. Personally I tried two other methods to close it first though:
I tried clicking in the blurred background, nothing happens here.
I tried using the back button on my mouse which made the background reload while the modal stays open.
- Since you're already running beta 2, if you want to try beta 3, it's up:
  ghcr.io/asimons04/tesseract:1.4.30-beta.3
  In addition to some other minor fixes, It also includes the list item bugfix you reported as well as the new modals that can be closed with the back button (or swipe or anything that tells the browser to 'go back').
  
  I just noticed that in nested modals, e.g. by clicking a post link inside a modal which opens another overlaying modal, the back button closes the background modal first and another back button click closes the foreground modal. I would expect the modals to close in the reverse order of them opening.
  
  Mostly fixed since -beta.3 (in addition to a few other rough edge cases).
  It's only relevant to the Post View modal, but it no longer creates a new history event if it's already open; it just replaces the content. The only remaining rough edge there, that I'm aware of, is that the history inside the post view modal is still de-coupled from the browser's history and you have to use the modal's back/forward buttons to page through those. e.g. if you click into a post, then click into a post/comment linked from the first. However, clicking 'back' once will now close that no matter what 'inner ' page it's on. (Previously, if you were 3 modals deep inside the post view modal, it would require 3 clicks/'back's to close; now it's just one).
  To get the inner history coupled to the browser history is going to require the full modal re-implementation I mentioned earlier.
  Beta 4 if you're interested: ghcr.io/asimons04/tesseract:1.4.30-beta.4
  
  Ah, I see. With beta-4 it's closing all nested modals at the same time using the back button. Sorry.
  
  Maybe I'm not sure what you mean by nested modals.
  When you open a post in a modal and then link to another post within it, it doesn't open a new modal; it just changes the content inside the existing one. So clicking back once, yes, does close "all" of them, but there was only ever one to close.
  When I describe a nested modal, I'm referring to different modal types (e.g. the user profile modal).
  So if I open a post in a modal, click the user name of the OP to bring up the profile modal, then that's a nested modal - clicking back would close the profile modal and clicking back again would close the post modal.
  Does that describe what you're seeing? If so, then that's intended.
  
  In lack of better words I used nested. This is what I meant:
  When you open a post in a modal and then link to another post within it, it doesn't open a new modal; it just changes the content inside the existing one. So clicking back once, yes, does close "all" of them, but there was only ever one to close
  In beta-3 it needed two back button clicks to close them both in a strange order, that isn't relevant with beta-4 anymore. 🫡
  
  Gotcha.
  I did not realize what a rabbit hole adding "open posts in modals" would be lol. After I thought I had it working, the edge cases just started piling up.
  
  Thanks for the heads-up. I had beta.1 still though ;) Closing that modals with the back button is working flawlessly 👍
- I tried using the back button on my mouse which made the background reload while the modal stays open.
  Actually, good news on that front. Despite me saying otherwise yesterday, I was able to patch the current modal implementation to make this work. I still plan to eventually overhaul the modal subsystem, but this is a good step in the right direction while keeping the core of it the same (meaning I can slip it into this release instead of a later one).
  It's going to take some extra testing once I'm done, but I am happy to have this working. On mobile, especially, being able to hit the back button to close modals is extremely welcome.
- FYI: You can press Escape to close them if they're in focus.
  I tried clicking in the blurred background, nothing happens here.
  That behavior is (intentionally) inconsistent. In many cases, it caused too many errant closures when you're in the middle of something (e.g. editing a post/comment) or when opening nested modals. I think at this point, it's mostly the exception when a modal closes by clicking out of it, so I should probably just standardize them all to that. You used to be able to swipe them left/right to close them, but that feature broke a while back. I need to see why, but it's been a known bug. Gestures still work in the zoomed images, so svelte-gestures does still seem to be working, just not on normal modals anymore. Like I said, known bug but low priority.
  I tried using the back button on my mouse which made the background reload while the modal stays open.
  Working on that. The modal subsystem (it's a whole thing) is kind of weirdly implemented; I've re-written most of it since forking from Photon forever ago, but it still works on the same mechanism. I basically need to completely re-write the way the modals are handled in order to make them work with the browser history so that clicking "back" will close them. That's on the roadmap but not going to happen in this release, unfortunately.
  
  I can give you a quick tip on the modal thing. Sveltekit recently added a thing called "shallow routing" that still handles things in JS but let's you go back and forwards with it. Check out the docs
  
  Yep, that's exactly what I'm doing now. Currently it's a hybrid of shallow routing and the existing Svelte store-based modals (shallow routing for the open state, store for the data), but I'm working on moving the data to the page state as well.
  How's Svelte 5? I've been kicking the can on that mostly to clean up and consolidate things since that should make the task easier.

21 comments