I just made my first Lemmy PR
I just made my first Lemmy PR
Description Right now if you try to login and you provide an unknown username/email or a wrong password, you will get no toast message. This PR adds toast messages for those scenarios and uses the ...
Let's gooooooooo
Not a bad idea! The attack vector issue they mention in the PR comments is valid, though. Not displaying those errors gives an attacker no confirmation that a user whose account they're trying to attack exists, if they're trying known used passwords. But good on you doing what you can to contribute to the project!
There should be an error, but it shouldn't say whether it was the email or password that was wrong.
Couldn't they just check instancename/u/accountname to see if the user exists?
Theoretically yeah. Depends on how quickly the attacker is working or if they have enough information to know where the account lives. If they're doing their due diligence, they could 100% confirm that. But if they aren't, they might just go to a random instance, try logging in, and see if it works.
By no means is it bad to offer a response, but it always risks giving an attacker more information than they need/the victim would want to have discovered about them.
yeeeeaaaaaaaa - see what you can do about hiding viewed content ^*
Sounds like a cool feature. I'm honestly down for doing a good chunk of
lemmy-uidev work as I'm kind of getting rusty in React with my new job being strictly backend these days.Yeah man... I am still waiting for that option that reddit has that hides any content you already upvoted/downvoted.
Thank you!
For a moment I thought you meant "Public Relations". 😅
Or "Press Release".