The best controller I arguably thing is the 360 controller. It just feels right to use in fighting games and fps. I like xboxs layout with the analog sticks.
Dualshock comes a close 2nd but was never a fan of the analog layout.
I find the n64 most jarring and I get that it was meant to be used differently for different games, but I still preferred the 3rd party options that took it closer to a standard gamepad.
8BitDo Pro 2. It's like a Playstation 2/3 and SNES controller did the fusion dance. I use it on my Switch and PC, response is great, tactile feel is amazing.
Just got this thing last week, I love it so far. Still haven't figured out how to make good use of the back paddles on PC, but even without those it's a great controller.