Cake days have an off-by-one error
Cake days have an off-by-one error
In my profile it says my cake day is today (June 13), but it was displaying a cake icon on my comments all day yesterday (June 12).
The icon was a black and white outline so I thought maybe it was showing it the day before on purpose so other people would see ahead of time, and that it would turn colorful on the actual day. But then midnight hit and it disappeared, so it must be a bug instead.
The calculation doesn't account for the leap year
NOOOOOO
That sounds plausible to be one problem, but it's also weird that it's different in two different places. There's some duplicate code that probably ought to be consolidated.
Assuming that @SorteKanin@feddit.dk is correct about this pull request merge, instances running v0.4.19, which was released last week, don’t have this problem anymore.
I already reported this a while ago and it has been fixed in a newer version. https://github.com/LemmyNet/lemmy-ui/issues/2441
LOL, that comment:
It sounds silly but I think this should probably be fixed for 0.19.4 so that people are updated before all the cake days in June start, there will be many first cake days
Meanwhile, lemmy.world is still on 0.19.3 as I type this. sad trombone noises
Lemmy updates are a little touchy and buggy, can't blame them for taking their time. It's only been out for like a week. They have to load a backup on another server and test it out to see if there's any issues with the upgrade and how long it'll take. They have to plan downtime and set aside enough time to do it, handle any issues and a potential rollback.
0.19.4 was only released a few days ago. And Lemmy.world, the biggest instance, sure ain't gonna be the guinea pig!
Mine started showing my cake around 7pm my time on the 12th, but only in desktop. Voyager app hasn't shown It yet. It has also shown my account as being a year old since early may on both desktop and mobile. Very strange.
Shows for me on Voyager now!
I forgot about cake days. My first account was lost to a server that went down but I'm almost there on this account!
on my cakeday.