What Am I Doing Wrong?
What Am I Doing Wrong?
If I run this
#!/bin/bash
ARCH=$(python fetch_architecture.py)
if [ $ARCH == "aarch64" -o $ARCH == "armv71" ] ; then
export PATH=/opt/local/llvm/bin:${PATH}
cd /app
RUSTFLAGS="-C linker=lld" wasm-pack build --target web --release plume-front
else
wasm-pack build --target web --release plume-front
fi
via the terminal, it works just fine. But when I run it via the Dockerfile,
COPY . .
RUN cargo install wasm-pack
RUN chmod a+x ./script/plume-front.sh
RUN sleep 1
RUN ./script/plume-front.sh
It says python: command not found and then [: too many arguments
Python is not found, so $ARCH gets assigned to
"", and you didn't double quote your variables in the comparison, so the code parses as[ == "aarch64"which is a syntax error.Also, maybe
uname -mcould work instead of that Python script.This was super insightful. Thank you so much.
What is your base image? It has no python installed.
Rust:1.78-bookworm.
Thank you, manually included it.
Python is not on the Path for docker. The error message "python: command not found" is then passed to the [ command (also called test) which says too many arguments.
Add the path /use/bin/ to your python command. Or figure out why it isn't on the docker path.
Thank you so much.
You should use
python3anyway notpython. The latter is sometimes Python 3, sometimes Python 2 and sometimes doesn't exist.python3works reliably, assuming you have it installed.(And assuming you aren't using the official Windows Python installer, but that doesn't seem like the case here!)
I ended up adding Python3 as it moaned when I just added Python. Thank you so much for your advice though. I'm grateful.
This is a docker/bash question, not a python question. Also reading the error message explains the problem.
Apologies, I thought it was Python because I was trying to execute a Python script. And double sorry for not knowing how to interpret the error message.
In addition to what everybody said:
- use bash strict mode
- use shellcheck
Those will help catch many problems before they happen or exactly when they happen.
P.S I would recommend against
set -o pipefailIt can introduce some very weird behaviour when it doesn't work.
Thank you so much. Especially for the Shell Check. That's an invaluable resource.
Could you elaborate on the weird behaviour introduced by
pipefail?This wiki explains one pitfall of nonstandard return codes in pipes. The other one that bit me is pipes that just stop existing (error 141).
It looks like you’ve already found an answer, but I have some follow up thoughts if you’re open. Seems like this Python script is used to determine system architecture, to facilitate running in many different environments. However, once you move into a Dockerfile, you have strict control over what arch you’re using (via selection of a base image). Rather than adding Python to the image, you might be able to cut out this conditional and simply hard-code the path which is appropriate for you.