Why was appointing Eich as CEO so controversial? It's because he donated $1,000 in support of California's Proposition 8 in 2008, which was a proposed amendment to California's state constitution to ban same-sex marriage.
Besides this I cannot find another good reason not to use brave. Nobody point to a specific line of code that ruins privacy, not enough reasons.
I've been using brave for over a year. I can't remember the last time I saw an ad on my screen. Now there might very well have been some But I have no memory of it.
They block the website's own ads, but inject their own instead. So the user still gets ads, but the profits go to Brave. I know that if the site's owner is aware of that and goes through the process of registering with Brave they get a share of the profits, but this should really be opt-in. As it is, the whole scheme is shady as fuck.
They do point out a couple of instances of questionable if not outright scummy things (e.g. the affiliate codes situation) but the article mostly gives off "stop using brave, I've decided it's cancelled" vibes.
They used to change the url which the user typed into the address bar to include a referral code. The article mentions going to binance.us, the browser appended a referral link to the url.
I stopped using it because it was kinda shitty. Some page elements in my webapps just didn't display or work correctly. Firefox is the more polished experience now. But it is kinda nice not having to morally justify your choice of browser, too.